Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDT: test app fixes #6897

Merged
merged 5 commits into from
Nov 11, 2020
Merged

GDT: test app fixes #6897

merged 5 commits into from
Nov 11, 2020

Conversation

maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Nov 4, 2020

#no-changelog

@@ -55,7 +55,7 @@ Shared library for iOS SDK data transport needs.
# Test app specs
if ENV['GDT_DEV'] && ENV['GDT_DEV'] == '1' then
s.app_spec 'TestApp' do |app_spec|
app_spec.platforms = {:ios => '8.0', :osx => '10.11', :tvos => '10.0'}
app_spec.platforms = {:ios => '9.0', :osx => '10.11', :tvos => '10.0'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10.12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I updated it to use version from the lib spec to avoid such mistakes in the future.

@maksymmalyhin maksymmalyhin merged commit 6e5f02d into master Nov 11, 2020
@maksymmalyhin maksymmalyhin deleted the mm/gdt-test-fixes branch November 11, 2020 17:56
@firebase firebase locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants